have mixinUpdate wait for entity to load first #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
mixinupdate
branch
from
9399a89 to
0ddcfd6
Compare
|
tests fail |
ngokevin
force-pushed
the
mixinupdate
branch
from
0ddcfd6 to
0fea7df
Compare
ngokevin
force-pushed
the
mixinupdate
branch
from
0fea7df to
edf51fe
Compare
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix culmination of weird cases when scene was still initializing, components were still initializing, node wasn't fully attached (so setAttribute wasn't fully overridden), and mixin update was called on a still initializing component, causing issues if init/update depended on el.sceneEl.