-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highRefreshRate property to enable 72hz mode on Oculus Browser (fix #3943) #3967
Conversation
Sorry @dmarcos, didn't see this question. Yes, what you are doing - seems correct to me (https://developer.oculus.com/documentation/oculus-browser/latest/concepts/browser-optimize-rendering/). |
@Artyom17 No problem. I know it's specific to Oculus Browser. Do you have an example with the |
This example works for me on Go: https://artyom17.github.io/webvr.info/samples/03-vr-presentation-72Hz.html (source https://github.com/Artyom17/webvr.info/blob/gh-pages/samples/03-vr-presentation-72Hz.html). |
@Artyom17 Thanks. I see. It seems I have to pass the flag in an object on Do you recommend us to default to 72Hz on Oculus Go or it should be opt-in for developers? |
@dmarcos I'd make it optional because of one issue - not all experiences would be able to make 72 fps on Go. |
@Artyom17 Thanks for the feedback |
d54a511
to
670c417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
docs/components/renderer.md
Outdated
@@ -29,6 +29,7 @@ The `renderer` system configures a scene's | |||
|-------------------------|---------------------------------------------------------------------------------|---------------| | |||
| antialias | Whether to perform antialiasing. If `auto`, antialiasing is disabled on mobile. | auto | | |||
| colorManagement | Whether to use a color-managed linear workflow. | false | | |||
| highRefreshRate | Oculus Browser has a 72hz optional mode vs. the default 60hz | false | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description can say what the property does a bit more directly.
Toggles 72fps/72hz on Oculus Browser. Will default to 60fps/60hz by default
the
highRefreshRate
flag onrequestPresent
does not seem to have any effect. Enabling high Refresh Rate onchrome://flags
does work as expected.@DigiTec Am I doing things correctly? I added a console message that shows the frame time.
This is WIP simplified for evaluation. The final API will use the renderer component.