Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the animation component for custom vec3 properties #4051

Merged
merged 2 commits into from
Mar 3, 2019

Conversation

Galadirith
Copy link
Contributor

@Galadirith Galadirith commented Mar 3, 2019

Description:

Fix the animation component to correctly animate vec3 properties of custom components. The current implementation handles the cases for position, scale and rotation but does not handle custom properties that do not represent properties of Object3D (PROP_POSITION, PROP_ROTATION, PROP_SCALE).

Changes proposed:

My thanks:

You all really inspire me ❤️ I am so grateful for all the hard work you've all put into developing A-Frame, and your commitment to an open VR web (sorry for being unprofessional and including this message in an PR).

@ngokevin
Copy link
Member

ngokevin commented Mar 3, 2019

Thanks much for the kind words, and the solid PR and tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants