Fix the animation component for custom vec3 properties #4051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the
animation
component to correctly animatevec3
properties of custom components. The current implementation handles the cases forposition
,scale
androtation
but does not handle custom properties that do not represent properties ofObject3D
(PROP_POSITION
,PROP_ROTATION
,PROP_SCALE
).Changes proposed:
animations
property reference used for customvec3
propertiesaframe/src/components/animation.js
Line 404 in ff2c7a4
to
animatables
as is used forposition
,scale
androtation
aframe/src/components/animation.js
Line 377 in ff2c7a4
My thanks:
You all really inspire me ❤️ I am so grateful for all the hard work you've all put into developing A-Frame, and your commitment to an open VR web (sorry for being unprofessional and including this message in an PR).