fix exponential deceleration in wasd-controls (fixes #4241) #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested experimentally with the Anime UI example. |
|
Awesome! Thanks for investigating and sharing the fix. Do you think it needs more testing? |
|
I think it's fine and ready to be merged. I've tested it quite extensively in Firefox and Chrome on macOS and I doubt that it would be OS-dependent. If someone has access to Windows machines running IE / Edge, it might be worth testing it there a bit. |
|
Cool thanks! Congrats for your first contribution 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a problem with the implementation. of exponential deceleration in
wasd-controls. The current implementation yields sudden stops when two frames are rendered in quick succession (significantly faster than the expected frame rate) and sudden jumps (in the order of several meters) in case of significant frame drops.Changes proposed:
The velocity update has been fixed according to the Stack Overflow question originally linked in the source code.
See also the discussion in #4241.