XR Cursor #5065
XR Cursor #5065
Conversation
|
|
||
| ```html | ||
| <a-scene | ||
| cursor__mouse="rayOrigin: mouse" |
There was a problem hiding this comment.
multiple components for this might feel like an overkill. wondering if we can simplify somehow. maybe rayOrigin: mouse also considers selectstart? Not a fan either because makes rayOrigin: mouse a bit deceiving (not really only about mouse anymore)
There was a problem hiding this comment.
I can think of a few situations in which a developer may prefer to handle all of their own XR select behaviours but still take advantage of the mouse cursor.
My XR Input Handling library in particular makes it really simple to start building your x-platform own XR cursor using the entity method of the cursor component component.
There was a problem hiding this comment.
Any other ideas to avoid the multiple component approach?
There was a problem hiding this comment.
have rayOrigin be an array of strings?
There was a problem hiding this comment.
array would weird too I think. probably even weirder. Let's go with the multiple components for now but I don't feel super comfortable. Thanks for the patience
|
Thanks for the hard work and patience. Left a few comments questions. Let me know what you think |
AdaRoseCannon
force-pushed
the
ar-cursor
branch
3 times, most recently
from
4fd6d06 to
8c4fbd6
Compare
|
Here is a demo of the current behaviour https://a-cursor-test.glitch.me/ I haven't tested it in VR yet, it should work even if the controllers aren't visible The user needs to have pressed the select button for mouseover to work |
| // if something was tapped on don't do ar-hit-test things | ||
| if ( | ||
| this.el.components.raycaster.intersectedEls.length && | ||
| this.el.sceneEl.components['ar-hit-test'] !== undefined && |
There was a problem hiding this comment.
Should the component ar-hit-test be set on init if rayOrigin xrselect? For this to work it depends on the user to also set ar-hit-test separately
There was a problem hiding this comment.
it's not so much a dependency just that things can get messy if both are being used so if the user is tapping on a 3d object then it shouldn't also interact with the real world behind it
|
This now includes a fix for ar-hit-test to end any active hit testing if it's disabled mid hit test |
| if (this.data.enabled === false) { | ||
| this.hitTest = null; | ||
| this.bboxMesh.visible = false; | ||
| } |
There was a problem hiding this comment.
Do we have to restore thee if the component is reenabled?
There was a problem hiding this comment.
They get reassigned when an xr selectstart happens
the mesh is made visible
and the hit-test set to the one corresponding to that input
|
I think this should only work when the XR Input's target ray mode NOT 'tracked-pointer' OR the Immersive Mode is AR I think that if you need to add the extra elements to render controllers then you probably want to handle the cursoring yourself |
| @@ -250,6 +284,23 @@ module.exports.Component = registerComponent('cursor', { | |||
| evt.preventDefault(); | |||
| } | |||
|
|
|||
| if (this.data.rayOrigin === 'xrselect' && evt.type === 'selectstart') { | |||
There was a problem hiding this comment.
Can this if be include in the if above to keep logic together
if (evt.type === 'selectstart') {
this.activeXRInput = evt.inputSource;
this.onMouseMove(evt);
this.el.components.raycaster.checkIntersections();
....
}
There was a problem hiding this comment.
disregard. github was not displaying enough context. sorry
|
Thanks for the patience. Awesome work! |
Description:
Allows the cursor component to be used with generic XR inputs without needing to be specifically attached to anything.
In particular this lets it work screen based AR
Changes proposed:
Demo:
https://www.youtube.com/watch?v=j1SNRmsgfOo