Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webxr unit tests #5227

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Webxr unit tests #5227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da92063
Initial version of WebXR tests, running on Chrome
diarmidmackenzie Feb 1, 2023
60d9d5c
Don't run tests when navigator.xr is not available (e.g. on Firefox)
diarmidmackenzie Feb 1, 2023
3e0a25a
Adjust formatting per PR feedback
diarmidmackenzie Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/scene/a-scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class AScene extends AEntity {
this.pointerRestrictedBound = function () { self.pointerRestricted(); };
this.pointerUnrestrictedBound = function () { self.pointerUnrestricted(); };

if (!isWebXRAvailable) {
if (!self.hasWebXR) {
// Exit VR on `vrdisplaydeactivate` (e.g. taking off Rift headset).
window.addEventListener('vrdisplaydeactivate', this.exitVRBound);

Expand Down Expand Up @@ -355,7 +355,7 @@ class AScene extends AEntity {
}
self.emit('enter-vr', {target: self});
// Lock to landscape orientation on mobile.
if (!isWebXRAvailable && self.isMobile && screen.orientation && screen.orientation.lock) {
if (!self.hasWebXR && self.isMobile && screen.orientation && screen.orientation.lock) {
screen.orientation.lock('landscape');
}
self.addFullScreenStyles();
Expand Down
2 changes: 2 additions & 0 deletions tests/__init.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ setup(function () {
getDevice: function () { return {requestPresent: function () {}}; },
isPresenting: function () { return true; },
setDevice: function () {},
setSession: function () { return Promise.resolve(); },
setFoveation: function () {},
setPoseTarget: function () {},
dispose: function () {},
setReferenceSpaceType: function () {},
enabled: false
},
dispose: function () {},
Expand Down
Loading