Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default value for new XRMode field #5390

Merged

Conversation

diarmidmackenzie
Copy link
Contributor

@diarmidmackenzie diarmidmackenzie commented Nov 19, 2023

Description:

1.5.0 docs say the default value for the new field is vr, ar, xr. In fact the default value is vr, and ar & xr are other possible values.

The relevant line of the schema is:

XRMode: {default: 'vr', oneOf: ['vr', 'ar', 'xr']}

Changes proposed:

Update docs to indicate the actual default value.

Relavent line of schema is:
```
XRMode: {default: 'vr', oneOf: ['vr', 'ar', 'xr']}
```
@dmarcos
Copy link
Member

dmarcos commented Nov 20, 2023

Thanks!

@dmarcos dmarcos merged commit 61f6442 into aframevr:master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants