Fix bug when loading models on child entities of controllers #5415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The various controls components handle the
model-loaded
event to configure the controller models. However, they don't check where themodel-loaded
event originates from. In case a child entity loads a model, the controls components would incorrectly assume it's the controller model that just loaded in.This actually causes issues in A-Painter where the
model-loaded
event of the brush-tip would trigger theonModelLoaded
for theoculus-touch-controls
(and others).Changes proposed:
onModelLoaded
checking that the event didn't originate from any child element