Make test teardown in __init.test.js synchronous #5477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removing the timeout from the
teardown
in__init.test.js
speeds up test execution significantly on my machine. According to the accompanying comment this timeout is there to letdetachCallbacks
clean themselves up before considering the teardown complete. However, custom elements v1 usesdisconnectedCallback
which is (effectively) synchronous, and therefore thesetTimeout
should have no bearing on them.Removing the timeout doesn't seem to have a negative impact. All tests are still green after making this change.
Changes proposed:
teardown
synchronous in__init.test.js
speeding up tests