Fix bug in a-scene's setAttribute in case of uninitialized systems #5482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
setAttribute
method in<a-scene>
prioritizes systems over components and other attributes. However, it did this by checking if the attribute name was present in the object with initialized systems. When programmatically creating ana-scene
these might not have been initialized yet.This PR changes the condition to first check if the attribute name matches a registered system.
Fixes: #3211
Changes proposed:
setAttribute
<a-scene>
'ssetAttribute