Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable feature flag on announcement banner #225

Merged
merged 11 commits into from
Aug 27, 2024
Merged

Conversation

davidlhw
Copy link
Contributor

@davidlhw davidlhw commented Aug 20, 2024

closes #135

Changes

  • added & enabled announcement-carousel feature flag on posthog
  • add posthog.identify on user.id at signin => required for feature flag conditional release
  • add posthog-node package and wrapper code
  • call feature flag on announcement banner component under home page

Implementation Details

see https://posthog.com/tutorials/nextjs-analytics#setting-up-and-using-feature-flags

  • posthog feature flags supports both client and server sided runtimes

Feature Flag on posthog

ENABLED - released ONLY for 100% of user matching the email test@smu.edu.sg

image

How to Test

  1. head to preview link
  2. see that announcement banner doesnt render
  3. login with test@smu.edu.sg account
  4. see that announcement banner renders

Preview / Screenshots

Not logged in - i.e user email is not test@smu.edu.sg

image

Logged in as test@smu.edu.sg

image

Logged in as test2@smu.edu.sg

image

Checklist

  • I have read the CONTRIBUTING document
  • I have tested the changes

@davidlhw davidlhw linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 4:44pm

@davidlhw davidlhw added the enhancement New user-facing feature or request. This Label is used as a category on release notes. label Aug 21, 2024
@davidlhw davidlhw self-assigned this Aug 21, 2024
@davidlhw davidlhw marked this pull request as ready for review August 21, 2024 16:15
@davidlhw davidlhw merged commit f010d94 into main Aug 27, 2024
5 checks passed
@davidlhw davidlhw deleted the 135-feature-flags branch August 27, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[devops] setup basic feature flags
1 participant