Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): review item component #64

Merged
merged 9 commits into from
Feb 3, 2024
Merged

Conversation

davidlhw
Copy link
Contributor

@davidlhw davidlhw commented Jan 21, 2024

‼️ Note: This PR is branched on top of feature/tag-component and should be merged only after #63 is merged

closes #51

changes

  • + <ReviewItem /> component & it's subcomponents under @/common/components/ReviewItem/
  • + new button variant rounded
  • update <LockCtaOverlay /> component to have a new variant for reviews (previously was only made for rating section)
  • + <ThumbsUpFilledIcon /> component
  • + index.ts for functions (every file in the @/common/functions dir should only house and export 1 function)

implementation

  • the "Show more" button doesnt do anything at this point as the modal component for the full review view is not yet ready

preview

image

image

Copy link

vercel bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 5:19pm

Copy link
Contributor

@Aztriltus Aztriltus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments!

src/common/components/ReviewItem/ReviewItem.tsx Outdated Show resolved Hide resolved
src/common/components/ReviewItem/ReviewItem.tsx Outdated Show resolved Hide resolved
@davidlhw davidlhw marked this pull request as draft January 26, 2024 07:59
@davidlhw davidlhw force-pushed the feature/review-item-component branch from 98dcb0f to 2eaf9f0 Compare January 31, 2024 06:53
@davidlhw davidlhw changed the base branch from feature/tag-component to main January 31, 2024 06:54
@davidlhw davidlhw marked this pull request as ready for review January 31, 2024 07:02
@davidlhw davidlhw requested a review from Aztriltus January 31, 2024 09:46
Copy link
Contributor

@Aztriltus Aztriltus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments!

src/common/components/ReviewItem/ReviewItem.tsx Outdated Show resolved Hide resolved
src/common/components/ReviewItem/ReviewItem.tsx Outdated Show resolved Hide resolved
src/common/components/Button/Button.theme.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Aztriltus Aztriltus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. Thanks for the changes!

@davidlhw davidlhw merged commit 0e57563 into main Feb 3, 2024
2 checks passed
@davidlhw davidlhw deleted the feature/review-item-component branch April 30, 2024 15:35
@davidlhw davidlhw added the enhancement New user-facing feature or request. This Label is used as a category on release notes. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat][UI] ReviewItem component
2 participants