Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): breadcrumb component #80

Merged
merged 15 commits into from
Apr 18, 2024
Merged

feat(ui): breadcrumb component #80

merged 15 commits into from
Apr 18, 2024

Conversation

davidlhw
Copy link
Contributor

@davidlhw davidlhw commented Mar 30, 2024 •
edited
Loading

‼️ NOTE: This PR will be rebased to main after #76 is merged. (do not merge before #76!)

closes #79

changes

  • + DropdownMenu component
  • + ChevronRightIcon icon for DropdownMenu component
  • + DotFilledIcon icon for DropdownMenu component
  • + DotsHorizontalIcon icon for Breadcrumb component
  • + SlashIcon icon for Breadcrumb component

testing

preview

breadcrumb

@vercel Vercel
Copy link

vercel bot commented Mar 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 10:03am

@davidlhw davidlhw linked an issue Mar 30, 2024 that may be closed by this pull request
[Feat][UI] Breadcrumb component #79
Closed
@davidlhw davidlhw self-assigned this Mar 31, 2024
@davidlhw davidlhw marked this pull request as ready for review March 31, 2024 14:19
Aztriltus
Aztriltus reviewed Mar 31, 2024
View reviewed changes
Copy link
Contributor

@Aztriltus Aztriltus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments!

src/common/components/DropdownMenu/DropdownMenu.tsx Outdated Show resolved Hide resolved
src/common/components/Breadcrumb/Breadcrumb.tsx Show resolved Hide resolved
src/common/components/Breadcrumb/Breadcrumb.tsx Outdated Show resolved Hide resolved
Aztriltus
Aztriltus previously approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@Aztriltus Aztriltus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM. Thanks for the changes

@davidlhw davidlhw force-pushed the feat/reviews-endpoint branch from 2798a25 to 4c2b3af Compare April 16, 2024 09:37
@davidlhw davidlhw changed the base branch from feat/reviews-endpoint to main April 16, 2024 09:57
@davidlhw davidlhw dismissed Aztriltus’s stale review April 16, 2024 09:57

The base branch was changed.

@davidlhw davidlhw force-pushed the feat/breadcrumb-component branch from 81dc68d to caf35e5 Compare April 16, 2024 10:02
@davidlhw
Copy link
Contributor Author

@Aztriltus could I trouble you for a quick review?

nothing code-wise has changed, just updated the PR to point to main
need a second pair of eyes just in case

@davidlhw davidlhw merged commit aa90f59 into main Apr 18, 2024
5 checks passed
@davidlhw davidlhw added the enhancement New user-facing feature or request. This Label is used as a category on release notes. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromeandrewong jeromeandrewong jeromeandrewong approved these changes

@Aztriltus Aztriltus Aztriltus left review comments

Assignees

@davidlhw davidlhw

Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat][UI] Breadcrumb component
3 participants
@davidlhw @Aztriltus @jeromeandrewong