Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Textarea component #82

Merged
merged 7 commits into from
Apr 21, 2024
Merged

feat(ui): Textarea component #82

merged 7 commits into from
Apr 21, 2024

Conversation

davidlhw
Copy link
Contributor

@davidlhw davidlhw commented Apr 1, 2024 •
edited
Loading

closes #33

changes

  • + Textarea component
  • + Textarea story

implementation

  • left out the left / right icon/content component

testing

preview

image

image

image

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 6:56pm

@davidlhw davidlhw self-assigned this Apr 1, 2024
@davidlhw davidlhw linked an issue Apr 1, 2024 that may be closed by this pull request
[Feat][UI] Textarea component #33
Closed
@davidlhw davidlhw force-pushed the feat/reviews-endpoint branch from 2798a25 to 4c2b3af Compare April 16, 2024 09:37
@davidlhw davidlhw force-pushed the feat/textarea-component branch from 77df187 to 6e62671 Compare April 16, 2024 10:08
@davidlhw davidlhw changed the base branch from feat/reviews-endpoint to main April 16, 2024 10:09
jeromeandrewong
jeromeandrewong previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jeromeandrewong jeromeandrewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidlhw davidlhw requested a review from Aztriltus April 18, 2024 04:32
@Aztriltus
Copy link
Contributor

Aztriltus commented Apr 20, 2024 •
edited
Loading

Hey @davidlhw. I've updated Figma with some hover and focus states. Can I trouble you to update them?

You can make use ring- and outline to achieve the focus. Maybe we can have a .focus-ring { @apply ... } class so that we can easily add focus-ring to components with just 1 class since the focus rings are all the same.

You can also use focus-visible:ring-* for the pseudo class instead of just focus: so it doesn't show that often

image

Figma link

@davidlhw davidlhw mentioned this pull request Apr 20, 2024
Closed
Aztriltus
Aztriltus previously approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@Aztriltus Aztriltus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise LGTM!

src/common/components/Textarea/Textarea.theme.ts Outdated Show resolved Hide resolved
src/common/components/Textarea/Textarea.theme.ts Outdated Show resolved Hide resolved
src/common/components/Textarea/Textarea.theme.ts Outdated Show resolved Hide resolved
@davidlhw davidlhw dismissed stale reviews from Aztriltus and jeromeandrewong via 7e7b5b2 April 20, 2024 18:55
Aztriltus
Aztriltus approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@Aztriltus Aztriltus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes

@davidlhw davidlhw merged commit db211c4 into main Apr 21, 2024
5 checks passed
@davidlhw davidlhw added the enhancement New user-facing feature or request. This Label is used as a category on release notes. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aztriltus Aztriltus Aztriltus approved these changes

@jeromeandrewong jeromeandrewong jeromeandrewong left review comments

Assignees

@davidlhw davidlhw

Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat][UI] Textarea component
3 participants
@davidlhw @Aztriltus @jeromeandrewong