Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phpstan ignore errors #1382

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

stakovicz
Copy link
Contributor

@stakovicz stakovicz marked this pull request as ready for review December 9, 2023 18:58
@agallou
Copy link
Member

agallou commented Dec 10, 2023

le fichier configs/application/config.php a été modifié en prod pour ajouter le return, du coup c'est prêt pour la mise en prod.

@agallou
Copy link
Member

agallou commented Dec 10, 2023

En fait pour compléter les choses il faudrait surement rajouter le return ici aussi :


(une des prochaines étapes sera surement de se passer ce ce fichier de configuration)

Copy link
Contributor

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moins d'erreurs moins d'erreurs @stakovicz ! 🤣

@stakovicz
Copy link
Contributor Author

En fait pour compléter les choses il faudrait surement rajouter le return ici aussi :

(une des prochaines étapes sera surement de se passer ce ce fichier de configuration)

Trop bien!
J'avais cherché un peu sans avoir trouvé comment c'était généré.

@stakovicz stakovicz merged commit d1d9ac2 into afup:master Dec 10, 2023
5 checks passed
@stakovicz stakovicz deleted the fix-phpstan-ignore-errors branch December 10, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants