-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pylint to pre-comit config #334
base: main
Are you sure you want to change the base?
Conversation
Currently, the repo uses ruff as the default linter in pre-commit and CI. There are some differences between pylint and ruff, as explained here:
My recommendation would be to stick with ruff as the default linter due to its speed. IMO, ff you wish to additionally lint and fix files to comply with pylint as well, that is the best approach. |
@davorrunje Thank you for the detailed comments. Change this PR to draft for now. |
Why are these changes needed?
When reviewing code, I saw many lint errors.
Add pylint to pre-commit to solve this.
Related issue number
Checks