Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support for Python 3.13 #53

Merged
merged 15 commits into from
Nov 21, 2024
Merged

Update support for Python 3.13 #53

merged 15 commits into from
Nov 21, 2024

Conversation

marklysze
Copy link
Collaborator

@marklysze marklysze commented Nov 20, 2024

Why are these changes needed?

With Python 3.13 released last month, any new updates or installs of Python will be version 3.13 and this is not supported at the moment for pip installing. Additionally, tests are not being run for Python 3.13.

Updated support for 3.13 for installing and testing.

Includes:

  • Fix for a test related to GraphRag
  • Fix for a test for llama indexindex conversable agent
  • Fix for a test due to a change in json error messages in Python 3.13

Important:

  • Numpy 2.1+ (Aug 2024) is the first version to support Python 3.13 - so we are including numpy 2.1 when using python 3.13. Hopefully this does not have any issues with other external packages.

Related issue number

Checks

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests failed. Should we worry about those?

@marklysze
Copy link
Collaborator Author

There are tests failed. Should we worry about those?

Let me check...

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark!

@qingyun-wu qingyun-wu merged commit 344c1b2 into main Nov 21, 2024
197 of 198 checks passed
@marklysze marklysze deleted the python313support branch November 26, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants