Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaptainAgent Finalize #61

Merged
merged 10 commits into from
Nov 22, 2024
Merged

CaptainAgent Finalize #61

merged 10 commits into from
Nov 22, 2024

Conversation

LeoLjl
Copy link
Collaborator

@LeoLjl LeoLjl commented Nov 21, 2024

Added notebook, test cases.

Why are these changes needed?

Related issue number

Checks

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Jiale!

@qingyun-wu
Copy link
Collaborator

@marklysze Could you take a look at the notebook content?

@marklysze
Copy link
Collaborator

@marklysze Could you take a look at the notebook content?

Yes, will do

@qingyun-wu
Copy link
Collaborator

@LeoLjl, could you add an auto-test in the workflow file? https://github.com/ag2ai/ag2/blob/main/.github/workflows/contrib-openai.yml

notebook/agentchat_captainagent.ipynb Outdated Show resolved Hide resolved
notebook/agentchat_captainagent.ipynb Outdated Show resolved Hide resolved
notebook/agentchat_captainagent.ipynb Outdated Show resolved Hide resolved
notebook/agentchat_captainagent.ipynb Outdated Show resolved Hide resolved
notebook/agentchat_captainagent.ipynb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants