Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Arabic Localization (partially, need help). #833

Merged
merged 3 commits into from
May 3, 2021
Merged

feat: Add Arabic Localization (partially, need help). #833

merged 3 commits into from
May 3, 2021

Conversation

hadialqattan
Copy link
Contributor

@hadialqattan hadialqattan commented Dec 24, 2020

Description

Support the Arabic language partially!

Related Issues

None.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

@hadialqattan hadialqattan changed the title Partial Arabic Language support! Added Arabic Localization (partially, need help). Dec 24, 2020
@jimman2003
Copy link
Contributor

You can draft your PR as to convey your intent better

@hadialqattan hadialqattan marked this pull request as draft December 25, 2020 16:08
@hadialqattan hadialqattan changed the title Added Arabic Localization (partially, need help). Add Arabic Localization (partially, need help). Dec 27, 2020
@agalwood agalwood changed the title Add Arabic Localization (partially, need help). feat: Add Arabic Localization (partially, need help). Dec 28, 2020
@agalwood agalwood marked this pull request as ready for review May 3, 2021 10:35
@agalwood agalwood merged commit 943830f into agalwood:master May 3, 2021
@AhmedElTabarani
Copy link
Contributor

AhmedElTabarani commented May 3, 2021

@agalwood
Why did you merged it now?
I was working on it

Now should I make a new pull request or update and edit this one?

@agalwood
Copy link
Owner

agalwood commented May 3, 2021

I misunderstood this message, thinking you have finished the translation, so I merged it.

a17assn approved these changes 13 hours ago

Please open a new PR, thank you. @AhmedElTabarani

@hadialqattan
Copy link
Contributor Author

@AhmedElTabarani Hi, kindly, please don't remove my name!

+ please let me know when you need any help, I'm a native Arabic speaker (from SA)!

Best,

Hadi.

@AhmedElTabarani
Copy link
Contributor

don't worry about your name, I will put your name only, I'll just do the rest.

@agalwood can't put more than one name right?

@AhmedElTabarani
Copy link
Contributor

AhmedElTabarani commented May 3, 2021

please let me know when you need any help, I'm a native Arabic speaker (from SA)!

Don't worry i got it ☺️، i am from Egypt anyway
Nice work to start this pull request.
I think after finish this, we should do a RTL UI !

@hadialqattan
Copy link
Contributor Author

don't worry about your name, I will put your name only, I'll just do the rest.

@agalwood can't put more than one name right?

I hope @agalwood allows us to put more than one name!

@hadialqattan
Copy link
Contributor Author

please let me know when you need any help, I'm a native Arabic speaker (from SA)!, I'm a native Arabic speaker (from SA)!

Don't worry i got it ☺️، i am from Egypt anyway
Nice work to start this pull request.
I think after finish this, we should do a RTL UI !

Nice!
Yeah, I agree, the LTR isn't that good with Arabic!

Appreciations 🌹

@agalwood
Copy link
Owner

agalwood commented May 4, 2021

Sorry, it looks like I am @ the wrong person : (

Your translation contributions are welcome, and I will add your names to the list of translation contributors.
@hadialqattan @AhmedElTabarani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants