[web] Small code improvement at ProposalSettingsSection

agama-project · Mar 7, 2024 · 338b8e5 · 338b8e5
1 parent 9ab4bf1
commit 338b8e5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 19 deletions.
diff --git a/web/src/components/storage/ProposalSettingsSection.jsx b/web/src/components/storage/ProposalSettingsSection.jsx
@@ -143,29 +143,24 @@ const SnapshotsField = ({
     onChange({ active: checked, settings });
   };
 
-  const configurableSnapshots = rootVolume.outline.snapshotsConfigurable;
+  if (!rootVolume.outline.snapshotsConfigurable) return;
 
   const explanation = _("Uses Btrfs for the root file system allowing to boot to a previous \
 version of the system after configuration changes or software upgrades.");
 
   return (
-    <If
-      condition={configurableSnapshots}
-      then={
-        <div>
-          <Switch
-            id="snapshots"
-            label={_("Use Btrfs Snapshots")}
-            isReversed
-            isChecked={isChecked}
-            onChange={switchState}
-          />
-          <div>
-            {explanation}
-          </div>
-        </div>
-      }
-    />
+    <div>
+      <Switch
+        id="snapshots"
+        label={_("Use Btrfs Snapshots")}
+        isReversed
+        isChecked={isChecked}
+        onChange={switchState}
+      />
+      <div>
+        {explanation}
+      </div>
+    </div>
   );
 };
 

diff --git a/web/src/components/storage/ProposalSettingsSection.test.jsx b/web/src/components/storage/ProposalSettingsSection.test.jsx
@@ -58,7 +58,7 @@ describe("if snapshots are not configurable", () => {
     props.settings = { volumes: [{ ...rootVolume, outline: { ...rootVolume.outline, snapshotsConfigurable: false } }] };
   });
 
-  it("renders the snapshots switch", () => {
+  it("does not render the snapshots switch", () => {
     plainRender(<ProposalSettingsSection {...props} />);
 
     expect(screen.queryByRole("checkbox", { name: "Use Btrfs Snapshots" })).toBeNull();