Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Martin Vidner <mvidner@suse.cz>
  • Loading branch information
jreidinger and mvidner committed Oct 30, 2023
1 parent 1157292 commit c3932bc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions service/lib/agama/config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def pick_product(product_id)
end

# hash of available base products for current architecture
# @return [Hash{String => Hash}] product_id => product
def products
return @products if @products

Expand Down
3 changes: 2 additions & 1 deletion service/lib/agama/product_reader.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

# Copyright (c) [2022] SUSE LLC
# Copyright (c) [2023] SUSE LLC
#
# All Rights Reserved.
#
Expand All @@ -25,6 +25,7 @@

module Agama
# This class is responsible for reading available products definition
# either from system path (`/usr/share/agama/products.d) or the git repo.
class ProductReader
include Yast::I18n

Expand Down
6 changes: 3 additions & 3 deletions service/run_tests_in_container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ if podman exec --workdir /checkout/service agama_ruby_tests rake test:unit; then
echo "Tests passed"
else
echo "Tests failed"
echo "To get into container use: podman attach agama_ruby_tests"
echo "git checkout is located at /checkout"
echo "To remove container use: podman rm agama_ruby_tests"
echo "To get into container use:"; echo " podman attach agama_ruby_tests"
echo " cd /checkout"
echo "To remove container use:"; echo " podman rm agama_ruby_tests"
fi

0 comments on commit c3932bc

Please sign in to comment.