[web] Show TPM reminder only if encryption was set

It does not make sense to display the reminder when the product has set
the TPM encryption method by default but the user did not set the
encryption.

web/src/components/core/InstallationFinished.jsx

@@ -74,9 +74,9 @@ function InstallationFinished() {
       const iguana = await client.manager.useIguana();
       // FIXME: This logic should likely not be placed here, it's too coupled to storage internals.
       // Something to fix when this whole page is refactored in a (hopefully near) future.
-      const { settings: { encryptionMethod } } = await client.storage.proposal.getResult();
+      const { settings: { encryptionPassword, encryptionMethod } } = await client.storage.proposal.getResult();
       setUsingIguana(iguana);
-      setUsingTpm(encryptionMethod === EncryptionMethods.TPM);
+      setUsingTpm(encryptionPassword?.length && encryptionMethod === EncryptionMethods.TPM);
     }
 
     // TODO: display the page in a loading mode while needed data is being fetched.

web/src/components/core/InstallationFinished.test.jsx

@@ -32,10 +32,12 @@ jest.mock("~/client");
 jest.mock("~/components/core/Sidebar", () => () => <div>Agama sidebar</div>);
 
 const finishInstallationFn = jest.fn();
+let encryptionPassword;
 let encryptionMethod;
 
 describe("InstallationFinished", () => {
   beforeEach(() => {
+    encryptionPassword = "n0tS3cr3t";
     encryptionMethod = EncryptionMethods.LUKS2;
     createClient.mockImplementation(() => {
       return {
@@ -45,7 +47,9 @@ describe("InstallationFinished", () => {
         },
         storage: {
           proposal: {
-            getResult: jest.fn().mockResolvedValue({ settings: { encryptionMethod } })
+            getResult: jest.fn().mockResolvedValue({
+              settings: { encryptionMethod, encryptionPassword }
+            })
           },
         }
       };
@@ -69,21 +73,46 @@ describe("InstallationFinished", () => {
     expect(finishInstallationFn).toHaveBeenCalled();
   });
 
-  describe("when TPM was set to decrypt automatically on each boot", () => {
+  describe("when TPM is set as encryption method", () => {
     beforeEach(() => {
       encryptionMethod = EncryptionMethods.TPM;
     });
 
-    it("shows the TPM reminder", async () => {
-      installerRender(<InstallationFinished />);
-      await screen.findAllByText(/TPM/);
+    describe("and encryption was set", () => {
+      it("shows the TPM reminder", async () => {
+        installerRender(<InstallationFinished />);
+        await screen.findAllByText(/TPM/);
+      });
+    });
+
+    describe("but encryption was not set", () => {
+      beforeEach(() => {
+        encryptionPassword = "";
+      });
+
+      it("does not show the TPM reminder", async () => {
+        const { user } = installerRender(<InstallationFinished />);
+        // Forcing the test to slow down a bit with a fake user interaction
+        // because actually the reminder will be not rendered immediately
+        // making the queryAllByText to produce a false positive if triggered
+        // too early here.
+        const congratsText = screen.getByText("Congratulations!");
+        await user.click(congratsText);
+        expect(screen.queryAllByText(/TPM/)).toHaveLength(0);
+      });
     });
   });
 
-  describe("when TPM was not set to decrypt automatically on each boot", () => {
-    it("does not show the TPM reminder", () => {
-      installerRender(<InstallationFinished />);
-      expect(screen.queryByText(/TPM/)).toBeNull();
+  describe("when TPM is not set as encryption method", () => {
+    it("does not show the TPM reminder", async () => {
+      const { user } = installerRender(<InstallationFinished />);
+      // Forcing the test to slow down a bit with a fake user interaction
+      // because actually the reminder will be not rendered immediately
+      // making the queryAllByText to produce a false positive if triggered
+      // too early here.
+      const congratsText = screen.getByText("Congratulations!");
+      await user.click(congratsText);
+      expect(screen.queryAllByText(/TPM/)).toHaveLength(0);
     });
   });
 });