Skip to content

Commit

Permalink
Filter only external connections (#1383)
Browse files Browse the repository at this point in the history
## Problem

During the installation the default NetworkManager profile tries to
apply DHCP over the wired and connected interfaces but the profile is a
volatile or only in memory one being skipped by agama.

In order to show the connection we should skip only the external
configured ones.

## Solution

Only skip external configured connections by now.
  • Loading branch information
imobachgs authored Jun 26, 2024
2 parents 8728a60 + 19acdfc commit e431778
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rust/agama-server/src/network/nm/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ impl<'a> NetworkManagerClient<'a> {
.build()
.await?;
let flags = proxy.flags().await?;
if flags > 0 {
// https://networkmanager.dev/docs/api/latest/nm-dbus-types.html#NMSettingsConnectionFlags
if flags & 8 != 0 {
log::warn!("Skipped connection because of flags: {}", flags);
continue;
}
Expand Down
8 changes: 8 additions & 0 deletions rust/package/agama.changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
-------------------------------------------------------------------
Wed Jun 26 12:56:31 UTC 2024 - Knut Anderssen <kanderssen@suse.com>

- Filter only external configured connections
(gh#openSUSE/agama#1383).
- Expose more details about devices status in the API
(gh#openSUSE/agama#1365).

-------------------------------------------------------------------
Wed Jun 26 10:29:05 UTC 2024 - José Iván López González <jlopez@suse.com>

Expand Down
6 changes: 6 additions & 0 deletions web/package/agama-web-ui.changes
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ Wed Jun 26 13:14:06 UTC 2024 - David Diaz <dgonzalez@suse.com>
- Bring back installer options when selecting a product
(gh#openSUSE/agama#1384).

-------------------------------------------------------------------
Wed Jun 26 11:54:41 UTC 2024 - Knut Anderssen <kanderssen@suse.com>

- Adapt the network page to the new UI guidelines
(gh#openSUSE/agama#1365).

-------------------------------------------------------------------
Wed Jun 26 08:31:31 UTC 2024 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

Expand Down

0 comments on commit e431778

Please sign in to comment.