Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size entry gets reset when switching from Range to Fixed #1277

Closed
kobliha opened this issue May 29, 2024 · 0 comments
Closed

Size entry gets reset when switching from Range to Fixed #1277

kobliha opened this issue May 29, 2024 · 0 comments
Labels
ux UX related bugs/improvements

Comments

@kobliha
Copy link
Contributor

kobliha commented May 29, 2024 •
edited
Loading

Size gets reset

I'm adding a separate /home filesystem.

  1. Add filesystem - /home
  2. First what I see is size, so I change the default 10 GiB to let's say 100 GiB
  3. Then I realize I really want exactly that size, but there is Range selected by default
  4. So I switch to Fixed
  5. The size is now reset back to 10 GiB

I know this might be a bit questionable, but I would expect the size not to reset back and I would expect the Mininum to be the Exact Size then.
@mvidner mvidner added the ux UX related bugs/improvements label Jun 28, 2024
mvidner added a commit that referenced this issue Jun 28, 2024
@mvidner
fix(web): VolumeDialog: share numeric value between Fixed and Range
3b4ab88 
In Add/Edit file system dialog (VolumeDialog), keep the numeric value
when switching between Fixed and Range sizing (gh##1277)

Do it by removing size and sizeUnit from formData and using minSize,
minSizeUnit for both roles.
@mvidner mvidner mentioned this issue Jun 28, 2024
Merged
1 task
mvidner added a commit that referenced this issue Jun 28, 2024
@mvidner
fix(web): VolumeDialog: share numeric value between Fixed and Range
83c2e78 
In Add/Edit file system dialog (VolumeDialog), keep the numeric value
when switching between Fixed and Range sizing (gh##1277)

Do it by removing size and sizeUnit from formData and using minSize,
minSizeUnit for both roles.
mvidner added a commit that referenced this issue Jun 28, 2024
@mvidner
VolumeDialog: share numeric value between Fixed and Range (#1412)
21f6b48 
## Problem

#1277 - "Size entry gets reset when switching from Range to Fixed"

## Solution

In Add/Edit file system dialog (VolumeDialog), keep the numeric value
when switching between Fixed and Range sizing.

Do it by removing `size` and `sizeUnit` from `formData` and using
`minSize`, `minSizeUnit` for both roles.

## Testing

- [x] *Tested manually*
@mvidner mvidner closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ux UX related bugs/improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvidner @kobliha