Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product selection stuck after registration #1891

Closed
jreidinger opened this issue Jan 13, 2025 · 2 comments
Closed

Product selection stuck after registration #1891

jreidinger opened this issue Jan 13, 2025 · 2 comments

Comments

@jreidinger
Copy link
Contributor

If you register product and go back to product selection it will stuck. Ideally this should be addresses two issues we have:

  1. do not allow to switch product after selection as it cause more troubles and benefit is small
  2. Properly report errors when you select product and get error from backend.
@dgdavid dgdavid mentioned this issue Jan 13, 2025
Merged
@dgdavid
Copy link
Contributor

dgdavid commented Jan 13, 2025

If you register product and go back to product selection it will stuck. Ideally this should be addresses two issues we have:

  1. do not allow to switch product after selection as it cause more troubles and benefit is small

This should be fixed with #1892

  1. Properly report errors when you select product and get error from backend.

I'd create a different issue for this one

dgdavid added a commit that referenced this issue Jan 14, 2025
@dgdavid
fix(web): do not allow changing product after registering one (#1892)
056e4c3 
## Problem

Although it is not possible to change a product after registering one,
web interface still rendering the _Change product_ action and does not
redirect to the root path when users try to navigates to the product
selection.

## Solution

Check if there is a registration code set for both, 

* Do not render the change product action
* Navigates to root path in case the user reach the selection product
path.

## Testing

- Added a new unit test
- Manually tested by @jreidinger
---

Related to 

  * #1891
  * #1882
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Jan 14, 2025
@bmwiedemann
Update agama-web-ui to version 0 / rev 8 via SR 1237711
4654cab 
https://build.opensuse.org/request/show/1237711
by user IGonzalezSosa + anag+factory
- Do not allow changing selected product after registering one
  (related to gh#agama-project/agama#1891).

- Version 11
@dgdavid dgdavid mentioned this issue Jan 16, 2025
Closed
@dgdavid
Copy link
Contributor

dgdavid commented Jan 16, 2025

I'm closing this because the first point was already fixed and the second one transferred to a new issue that later was converted to a discussion.

@dgdavid dgdavid closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jreidinger @dgdavid