Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching display language via the URL parameter to es_AR does not fallback to es_ES, it uses English instead #860

Closed
Tracked by #1746
lslezak opened this issue Nov 13, 2023 · 7 comments
Closed
Tracked by #1746

Switching display language via the URL parameter to es_AR does not fallback to es_ES, it uses English instead #860

lslezak opened this issue Nov 13, 2023 · 7 comments
Assignees
@imobachgs
Labels
bug Something isn't working good first issue Good for newcomers translations Translation related problem

Comments

@lslezak
Copy link
Contributor

lslezak commented Nov 13, 2023

Problem

  • The UI language can be switched by the URL parameter ?lang=es_ES to Spanish, that works fine
  • But when the requested language is not supported it falls back to English, not to a similar language
  • Example: ?lang=es_AR (Spanish in Argentina) is not directly supported, but it should fallback to es_ES as it is probably very close, definitely much closer than English
@lslezak lslezak added bug Something isn't working translations Translation related problem labels Nov 13, 2023
@imobachgs imobachgs mentioned this issue Jan 24, 2024
Closed
@imobachgs imobachgs added the good first issue Good for newcomers label Jan 24, 2024
@dgdavid
Copy link
Contributor

dgdavid commented Feb 19, 2024

@nagu165,

Just out of curiosity. Did you have a look to this? Your answer at #932 (comment) made me though you will try it.

@nagu165
Copy link
Contributor

nagu165 commented Feb 28, 2024

@nagu165,

Just out of curiosity. Did you have a look to this? Your answer at #932 (comment) made me though you will try it.

yes sir, I did.
I also tried to solve the issue but couldn't solve it properly. I had exams going on so kept it on hold. I will try this again.
Thank you.

@dgdavid
Copy link
Contributor

dgdavid commented Feb 28, 2024 •
edited
Loading

@nagu165,
Just out of curiosity. Did you have a look to this? Your answer at #932 (comment) made me though you will try it.

yes sir, I did. I also tried to solve the issue but couldn't solve it properly.

No problem, let us known if there is any doubt we can help with.

I had exams going on so

Good luck 🤞 Hit it hard 💪 🤓

kept it on hold. I will try this again. Thank you.

Thanks to you!

@nagu165
Copy link
Contributor

nagu165 commented Mar 13, 2024

Hello sir, I am really sorry for no response. I have tried to solve the issue but i couldn't. so i think i need to learn a lot. I'll start contributing again once i feel confident.
Thank you so much for helping me a lot.

@imobachgs
Copy link
Contributor

Hello sir, I am really sorry for no response. I have tried to solve the issue but i couldn't. so i think i need to learn a lot. I'll start contributing again once i feel confident. Thank you so much for helping me a lot.

That's no problem. Feel free to try it again in the future. Thanks for your interest in the project. Good luck!

@imobachgs imobachgs self-assigned this Nov 12, 2024
@imobachgs
Copy link
Contributor

I will fix this while working on bsc#1233160.

@imobachgs imobachgs mentioned this issue Nov 13, 2024
Merged
5 tasks
imobachgs added a commit that referenced this issue Nov 14, 2024
@imobachgs
fix: properly handle installer language changes (#1746)
198576f 
## Problem

Problems:

- [x] It is not possible to change the language. See
[bsc#1233160](https://bugzilla.suse.com/show_bug.cgi?id=1233160).
- [x] Changing to Portuguese does not work (it might be related to the
code, `pt-BR`).
- [x] The message while reloading the software translations is in the
old language.
- [x] #1724
- [x] #860

## Solution

Fix the D-Bus path of the LocaleProxy to the Manager's
`org.opensuse.Agama1.Locale` interface.

## Testing

- Tested manually
@imobachgs
Copy link
Contributor

Fixed with #1746.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imobachgs imobachgs

Labels
bug Something isn't working good first issue Good for newcomers translations Translation related problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@imobachgs @lslezak @dgdavid @nagu165