Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: UI code pruning and clean up round #1 #1441

Merged
merged 38 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2f3174d
web: stop using classNames for proposal actions
dgdavid Jul 4, 2024
883df16
web: drop dead CSS rules
dgdavid Jul 4, 2024
d31f5f0
web: drop CSS rule
dgdavid Jul 4, 2024
a0bd2fc
web: drop CSS rule for wifi menu toggler
dgdavid Jul 4, 2024
9fb9a1e
web: drop kebab menu CSS selectors
dgdavid Jul 4, 2024
730a30b
web: drop CSS rule for volumes list
dgdavid Jul 4, 2024
557ac56
web: drop CSS rules related to former patterns selector
dgdavid Jul 4, 2024
0ad8666
web: drop dead CSS selector
dgdavid Jul 4, 2024
17c77ff
web: remove not needed CSS selectors
dgdavid Jul 4, 2024
fe0d7d4
web: drop more CSS selectors
dgdavid Jul 4, 2024
82ebb0e
web: drop CSS related to custom selection list
dgdavid Jul 5, 2024
a5002d8
web: drop CSS related to deleted core/Tag component
dgdavid Jul 5, 2024
e5ca1cb
web: drop CSS related to deleted ControlledPanels component
dgdavid Jul 5, 2024
d652473
web: drop orphan CSS
dgdavid Jul 5, 2024
b70dfc1
web: remove CSS related to former Reminder component
dgdavid Jul 5, 2024
d8eb8fe
web: remove tmp-hint CSS class
dgdavid Jul 5, 2024
271d219
web: remove not needed agama/field CSS rules
dgdavid Jul 5, 2024
b83a2f1
web: drop boot-form orphan CSS rules
dgdavid Jul 5, 2024
8bf0866
web: drop assets/layout.scss files
dgdavid Jul 5, 2024
5197c28
web: remove few alignment CSS rules
dgdavid Jul 5, 2024
7cd5cdf
web: delete orphan CSS rules for formatting text
dgdavid Jul 5, 2024
1b15d3e
web: drop full-size CSS rule
dgdavid Jul 5, 2024
8322f7b
web: remove unused CSS utils
dgdavid Jul 5, 2024
6e22da7
web: delete .visually-hidden CSS util
dgdavid Jul 5, 2024
f8302b3
web: delete CSS utils for adding shadows
dgdavid Jul 5, 2024
4b8a3c6
web: delete not used CSS utilities
dgdavid Jul 5, 2024
144c47c
web: drop a padding CSS rule
dgdavid Jul 5, 2024
34b51d6
web: delete .large CSS rule
dgdavid Jul 5, 2024
3d556b5
web: delete .height-75 CSS rule
dgdavid Jul 5, 2024
8511306
web: drop dead CSS variables
dgdavid Jul 10, 2024
4a50d9c
fix(web): adapt ServerError component
dgdavid Jul 10, 2024
00e5b44
web: drop PF/EmptyStateBody CSS override
dgdavid Jul 11, 2024
ff079ba
web: type fixes
dgdavid Jul 11, 2024
2e4b074
web: drop duplicate typedef imports
dgdavid Jul 11, 2024
76d7236
web: drop PF/Progress CSS overrides
dgdavid Jul 11, 2024
a030f8d
web: delete core/FileViewer component
dgdavid Jul 11, 2024
cb22931
web: delete core/PageMenu component
dgdavid Jul 11, 2024
6f7c158
web: delete core/Selector component
dgdavid Jul 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 6 additions & 131 deletions web/src/assets/styles/app.scss
Original file line number Diff line number Diff line change
@@ -1,45 +1,11 @@
// Make proposal actions compact
.proposal-actions li + li {
margin-block-start: 0;
}

.proposal-action--delete {
font-weight: bold;
}

// Align the expandable-actions with the actions list
// See https://www.patternfly.org/components/list#css-variables
.expandable-actions {
// --pf-v5-c-list--PaddingLeft - --pf-v5-c-list--nested--MarginLeft - --pf-v5-c-list--m-icon-lg__item-icon-MinWidth
margin-inline-start: calc(var(--pf-v5-global--spacer--lg) - var(--pf-v5-global--spacer--sm) - var(--pf-v5-global--icon--FontSize--sm));
}

.expandable-actions > div {
margin-block-start: 0;
}

// Using a "selected-product" CSS class because sadly we cannot use
// ".pf-v5-c-card:has(> input[type="radio"]:checked)" yet
//
// See:
// - https://drafts.csswg.org/selectors/#relational
// - https://caniuse.com/css-has
.pf-v5-c-card.selected-product {
--pf-v5-c-card--BoxShadow: var(--pf-v5-global--BoxShadow--md);

.pf-v5-c-radio {
// https://drafts.csswg.org/css-ui/#widget-accent
// https://caniuse.com/mdn-css_properties_accent-color
accent-color: var(--color-primary-darkest);
}

.pf-v5-c-radio__label {
color: var(--color-primary);
font-weight: bold;
// Better alignment for expandable section with a sibling list
ul.pf-v5-c-list + div.pf-v5-c-expandable-section {
> button {
margin-inline-start: calc(var(--pf-v5-global--spacer--lg) - var(--pf-v5-global--spacer--sm) - var(--pf-v5-global--icon--FontSize--sm));
}

.pf-v5-c-radio__description {
color: var(--color-primary-darkest);
> div {
margin-block-start: 0;
}
}

Expand All @@ -56,97 +22,6 @@ button.remove-link:hover {
color: var(--pf-v5-c-button--m-danger--BackgroundColor);
}


button.hidden-popover-button {
visibility: hidden;
display: inline;
}

.wifi-network-menu button.pf-v5-c-dropdown__toggle {
padding-right: 0;
}

.keep-words {
word-break: keep-all;
}

button.kebab-toggler {
padding-right: 0;

svg {
vertical-align: middle;
}
}

.volumes-list {
.pf-v5-c-label {
margin-inline-end: 5px;
}
}

.pattern-container {
display: grid;
grid-template-columns: 16px auto;
grid-template-rows: auto auto;
gap: 0.2em 1em;
grid-auto-flow: row;
grid-template-areas:
"checkbox label"
"empty summary";
margin-bottom: 1em;
padding: 0.5em;
border-radius: 5px;
}

.pattern-container:hover {
background-color: #eee;
}

.pattern-label {
display: grid;
grid-template-columns: 32px auto;
grid-template-rows: auto;
gap: 0 1em;
grid-auto-flow: row;
grid-template-areas: "label-icon label-text";
grid-area: label;
}

.pattern-label-icon {
grid-area: label-icon;
align-self: center;
}

.pattern-label-text {
grid-area: label-text;
font-size: 110%;
font-weight: bold;
justify-self: start;
align-self: center;
}

.pattern-summary {
grid-area: summary;
color: #666;
}

.pattern-checkbox {
grid-area: checkbox;
justify-self: center;
align-self: center;
}

.pattern-group-name {
font-size: 120%;
}

.locale-container {
display: grid;
grid-template-columns: 1fr 1fr;
gap: 0 1em;
width: 100%;
}

.first-username-dropdown {
position: absolute;
width: 100%;
Expand Down
Loading
Loading