Replace yastd-proxy with cockpit infrastructure #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The proxy is used when running the "start" command.
* The yastd-proxy is not needed anymore.
* Otherwise it will not work under cockpit-ws
* It allows to inject a shared installerClient in any component.
* The global state does not need to know the list of languages.
* The global state does not need to know the list of products.
* The global state does not need to know the list of disks or the storage proposal.
* Let's use npm by now.
* The web UI relies now on Cockpit, so the proxy is not needed anymore.
imobachgs
force-pushed
the
use-cockpit
branch
from
e57ecd9
to
62f6151
Compare
dgdavid
approved these changes
Feb 2, 2022
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
dgdavid
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the idea of this PR was to switch from
yastd-proxytocockpit. By the way, we introduced additional changes and improvements. I will open an additional PR adding more documentation, especially about how the code is organized.cockpit-wsinstead ofyastd-proxy.useInstallerClienthook to inject the client where needed.Trello: https://trello.com/c/vXkc57mV/