Added DASDs format confirmation dialog #1618
Open
+166
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
confirm_format
branch
from
f5760c5
to
895f0c7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
teclator
force-pushed
the
confirm_format
branch
from
b893036
to
daaf259
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dgdavid
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Thanks @teclator
It LGTM 👍 but if I'm not wrong we're avoiding merges today. Ask @imobachgs if you're in a hurry.
dgdavid
reviewed
Sep 23, 2024
dgdavid
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/9TprKm3i
As formatting a device is a dangerous action and could irreversibly destroy data on the target disk it would be nice to have a confirmation before continue.
In the current PR we added that confirmation dialog.
Screenshots