-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the software context is ready #820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please put something meaningful in the PR description
Sure! I am just trying to figure out why Playwright tests are failing (they work on my machine:tm:). |
d3088ad
to
6f28d77
Compare
8bc76e0
to
7572e68
Compare
7572e68
to
1dc911d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
For a short time (a fraction of a second), the overview page is shown even if you have not selected a product. It's not a problem at all for a human, but something nasty for automated testing.
Solution
Do not load the application until the software context is ready.
Testing