Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the software context is ready #820

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Oct 26, 2023

Problem

For a short time (a fraction of a second), the overview page is shown even if you have not selected a product. It's not a problem at all for a human, but something nasty for automated testing.

Solution

Do not load the application until the software context is ready.

Testing

  • Adapted a new unit test
  • Tested manually

@coveralls
Copy link

coveralls commented Oct 26, 2023

Coverage Status

coverage: 75.125% (+0.01%) from 75.114% when pulling 1dc911d on init-software-context into 320b580 on master.

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please put something meaningful in the PR description

web/src/App.test.jsx Outdated Show resolved Hide resolved
@imobachgs
Copy link
Contributor Author

LGTM, but please put something meaningful in the PR description

Sure! I am just trying to figure out why Playwright tests are failing (they work on my machine:tm:).

@imobachgs imobachgs changed the title Init software context Ensure the software context is ready Oct 26, 2023
@imobachgs imobachgs force-pushed the init-software-context branch 4 times, most recently from 8bc76e0 to 7572e68 Compare October 26, 2023 13:17
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit b5920ac into master Oct 26, 2023
10 checks passed
@imobachgs imobachgs deleted the init-software-context branch October 26, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants