Ensure the software context is ready #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
approved these changes
Oct 26, 2023
Sure! I am just trying to figure out why Playwright tests are failing (they work on my machine:tm:). |
imobachgs
force-pushed
the
init-software-context
branch
from
d3088ad
to
6f28d77
Compare
imobachgs
force-pushed
the
init-software-context
branch
4 times, most recently
from
8bc76e0
to
7572e68
Compare
imobachgs
force-pushed
the
init-software-context
branch
from
7572e68
to
1dc911d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For a short time (a fraction of a second), the overview page is shown even if you have not selected a product. It's not a problem at all for a human, but something nasty for automated testing.
Solution
Do not load the application until the software context is ready.
Testing