Split products #822
Split products #822
Conversation
Co-authored-by: Martin Vidner <mvidner@suse.cz>
products.d/ALP-Dolomite.yaml
Outdated
| @@ -0,0 +1,103 @@ | |||
| - id: ALP-Dolomite | |||
| name: SUSE ALP Dolomite | |||
| description: 'SUSE ALP Dolomite is a minimum immutable OS core, focused on | |||
There was a problem hiding this comment.
BTW did you know that this YAML syntax means that the resulting string has no newlines?
https://yaml.org/spec/1.2.2/#732-single-quoted-style
There was a problem hiding this comment.
no, but maybe it is good that wrapping will be done as required?
products.d/ALP-Dolomite.yaml
Outdated
| security: | ||
| tpm_luks_open: true | ||
| lsm: selinux | ||
| available_lsms: |
There was a problem hiding this comment.
I have used available_lsms as an example, grepping the repository and finding no documentation. The only documentation is the code actually using the config data.
Since we're packaging the product data in separate RPMs, it may start to be an issue.
It may be OK if we are the only team actually touching these RPMs.
Related: https://trello.com/c/DkQ0GRqH/192-agama-move-agama-configuration-from-yaml-to-json
There was a problem hiding this comment.
yeap, documentation is for sure needed. BTW documentation is at https://github.com/openSUSE/agama/blob/master/doc/yaml_config.md we just forgot to update it
There was a problem hiding this comment.
For now, it is OK to update that document. At some point, we should start thinking about adding a mechanism (based on JSON or YAML or whatever-format-we-use) to validate the configuration.
| ------------------------------------------------------------------- | ||
| Mon Oct 30 14:38:51 UTC 2023 - Josef Reidinger <jreidinger@suse.com> | ||
|
|
||
| - Initial split of products |
There was a problem hiding this comment.
I would add a reference to this PR and/or #602.
service/conf.d/ssl.yaml
Outdated
| @@ -0,0 +1,4 @@ | |||
| web: | |||
There was a problem hiding this comment.
According to the content, cockpit.conf or web.conf could be a better name.
Co-authored-by: Martin Vidner <mvidner@suse.cz>
Problem
All products are now defined inside agama.yaml and modified for each type of live iso.
Solution
Separate products to own files and also allow them to be in separate rpms.
The default web configuration will live in its own file.
Also for easier testing new script to run testsuite in container was added.
TODO: After merge also iso creation needs to be modified to use new rpms.
Testing