Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes to network model #824

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

jcronenberg
Copy link
Contributor

@jcronenberg jcronenberg commented Oct 27, 2023

Problem

No routes in network model

Solution

Add a new IpRoute struct and add separate routes4 and routes6 to IpConfig

Testing

  • Extended unit tests
  • Tested manually
  • Tested using the wicked migration

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good. I just added some minor comments. Please remember to update the changes file, if you don't mind.

rust/agama-dbus-server/src/network/nm/dbus.rs Outdated Show resolved Hide resolved
rust/agama-dbus-server/src/network/nm/dbus.rs Outdated Show resolved Hide resolved
rust/agama-dbus-server/src/network/nm/dbus.rs Outdated Show resolved Hide resolved
@jcronenberg
Copy link
Contributor Author

jcronenberg commented Nov 14, 2023

Please remember to update the changes file, if you don't mind.

Do you mean agama-cli.changes? Because this PR alone will have AFAICT no direct impact on agama-cli yet. This PR isn't touching the settings parts. I thought about implementing that as well, but thought this is something where you guys maybe want to decide e.g. the format of the settings etc. If you want we could discuss this as well and I'll implement something like that too, but that's up to you.

@imobachgs
Copy link
Contributor

Yes, no problem, we will take care of the settings part. However, as you can use agama-lib as a library, I would mention the changes in the agama-cli.changes file anyway. Something like:

* Add support for routing to the network model (gh#openSUSE/agama#824).

That would be enough. Otherwise, it LGTM (waiting for another tests run).

@imobachgs
Copy link
Contributor

@jcronenberg Thank you!

@imobachgs imobachgs merged commit 9e62e88 into agama-project:master Nov 14, 2023
1 check passed
@jcronenberg jcronenberg deleted the nm_routing branch November 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants