Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the "InstallationFinished" again #825

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Display the "InstallationFinished" again #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cfb030
Display the "InstallationFinished" again
imobachgs Oct 27, 2023
967f6c5
Update the changes file
imobachgs Oct 27, 2023
98de4af
Pass the status
imobachgs Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions web/package/cockpit-agama.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Fri Oct 27 10:25:46 UTC 2023 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Display the "Congratulations" message at the end of the
installation again (gh#openSUSE/agama#825).

-------------------------------------------------------------------
Thu Oct 26 16:07:02 UTC 2023 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

Expand Down
2 changes: 1 addition & 1 deletion web/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function App() {
}

if (phase === INSTALL) {
return <Installation />;
return <Installation status={status} />;
}

return <Outlet />;
Expand Down
12 changes: 2 additions & 10 deletions web/src/components/core/Installation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,11 @@
* find current contact information at www.suse.com.
*/

import React, { useEffect, useState } from "react";
import { useInstallerClient } from "~/context/installer";
import React from "react";
import { InstallationProgress, InstallationFinished } from "~/components/core";
import { IDLE } from "~/client/status";

function Installation() {
const client = useInstallerClient();
const [status, setStatus] = useState(undefined);

useEffect(() =>
client.manager.onStatusChange(setStatus), [client.manager]
);

function Installation({ status }) {
imobachgs marked this conversation as resolved.
Show resolved Hide resolved
return (status === IDLE) ? <InstallationFinished /> : <InstallationProgress />;
}

Expand Down
Loading