[Service] Delegate TPM-based encryption to YaST #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| # @todo Perform a real D-Bus call. | ||
| def AvailableAll(_package_names) | ||
| true |
There was a problem hiding this comment.
Can we always assume true?
There was a problem hiding this comment.
No. We can't. It's the same TODO we have for Available in the line above.
There was a problem hiding this comment.
But not that you mention it, I will search for the corresponding Trello card/Github issue/Whatever and will reference it here.
There was a problem hiding this comment.
Everything originated here (it says "We need to add support for Package#Available and Package#Installed to D-Bus):
But I don't see any follow-up card or issue to track it. So I will create one.
There was a problem hiding this comment.
Done. Now we have https://trello.com/c/oRcZ5P5k/251-implement-missing-software-methods
joseivanlopez
requested changes
Nov 2, 2023
joseivanlopez
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Encryption with TPM-unlocking was implemented (in a pretty hacky way) directly at Agama.
Solution
This PR goes together with yast/yast-storage-ng#1363
Now
Y2Storagetakes care of most things.As a bonus, the storage finisher is now called. We overlooked that in the past and it takes care of some relevant things like copying the multipath configuration to the target system.