Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve network tests reliability #834

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Improve network tests reliability #834

merged 3 commits into from
Nov 2, 2023

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Oct 31, 2023 •
edited
Loading

Problem

According to #828 the tests are not passing in aarch64. While investigating the issue I found out that occasionally there is a problem with s390x too.

Solution

  • Add a function to retry an async call. Please, use it only where needed, as it can slow the tests.
  • Use only one job to run tests on aarch64.

Testing

  • Testing in my OBS home project.

@imobachgs
Retry some async functions in network tests
31f3b72 
* Some tests are failing in aarch64 and s390x (see #812).
@imobachgs imobachgs marked this pull request as draft October 31, 2023 12:51
@imobachgs imobachgs mentioned this pull request Oct 31, 2023
Closed
@imobachgs imobachgs marked this pull request as ready for review November 2, 2023 09:22
@imobachgs imobachgs merged commit 335066c into agama-project:master Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imobachgs @jreidinger