Replace async_std with tokio
#848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Nov 15, 2023
jreidinger
reviewed
Nov 15, 2023
jreidinger
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding async/await, Rust does not endorse a runtime. There are different alternatives, but the most popular are tokio, async-std and smol.
At the beginning of this project, we chose
async-stdbecause it was the default for zbus. However, zbus offers support for Tokio.Taking into account that Tokio is the most used runtime in the Rust ecosystem, I am considering whether we should make the switch.
This pull request adapts the code to replace
async-stdwithtokio. Sure, it deserves some discussion first, so I am opening it as a draft.Testing
In addition to the existing tests (including CI), I am building an agama-live including the code in this
tokiobranch.