Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and upload the product POT file to allow translating the product descriptions #851

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Nov 7, 2023

Problem

  • The product descriptions in the ./products.d/*.yaml files are not translated
  • That looks bad as those texts are quite long and displayed in the very first Agama dialog

Solution

  • Extract the description texts from the YAML files
  • Upload them to the agama-weblate repository

Testing

TODO

  • Set up a new Weblate translation project so the translators can actually translate the texts
  • Implement merging the translations back to the original YAML files
  • Use the translations in the backend/frontend
  • Document the product translations (if somebody wants to define own product)

@coveralls
Copy link

Coverage Status

coverage: 75.063%. remained the same
when pulling b459244 on lslezak:master
into f1a8318 on openSUSE:master.

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might be interesting to document this further just in case someone is interested on creating its own product.

@lslezak lslezak merged commit 9b67fbe into agama-project:master Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants