Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration support #869

Merged
merged 109 commits into from
Nov 15, 2023
Merged

Registration support #869

merged 109 commits into from
Nov 15, 2023

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Nov 15, 2023 •
edited
Loading

Implementation of product registration. This is a feature branch that contains several PRs. Everything was already reviewed in each separate PR.

In short, this branch adds:

  • A D-Bus API for registering a product.
  • A web interface for registration.

For more details see:

joseivanlopez and others added 30 commits October 4, 2023 14:43
@joseivanlopez
[service] Some renames in Software D-Bus API
b48ae86
@joseivanlopez
[service] WIP Registration D-Bus API
8bbd567
@jreidinger
add registration mock class
c39c376
@joseivanlopez
[service] Replace Validation by Issues interface
e50337b
@joseivanlopez
[service] Fix names
c5535f7
@joseivanlopez
[service] WIP return error number and message
851e85f
@jreidinger
initial forst working POC
9300a72
@joseivanlopez
[service] More fixes to adapt to changes in D-Bus API
12102fd
@joseivanlopez
[web] Adapt UI to D-Bus API changes
78c4df0
@jreidinger
use suse connect directly without yast
8ac9699
@joseivanlopez
[service] Work on some tests
cdc9bb4
@joseivanlopez
[service] Small fixes
f16b07e
@joseivanlopez
[service] Improve generation of connect result
94dd896
@jreidinger
fix missing require
b0734a5
@jreidinger
make rubocop happy
551a643
@jreidinger
fix typo
4098011
@jreidinger
drop removed method from y2-registration
834a7dc
@jreidinger
try registation without release type
d875395
@joseivanlopez
[service] Small improvements
861c202
@joseivanlopez
[service] Fix tests
719d421
@joseivanlopez
[service] Continue working on the D-Bus API
9881d89
@jreidinger
support deregister
4f90278
@joseivanlopez
[service] Add registration issue
fe89d84
@jreidinger
add to deregister also code
7ccfa41
@jreidinger
fix typo and order
60ab7ba
@jreidinger
fix base product cannot be deactivated
18f5de9
@jreidinger
remove credentials file
a4cc72b
@jreidinger
properly uninitialize internal variables
895a092
@joseivanlopez
[service] Add Product and ProductBuilder
cd6a22b
@joseivanlopez
[service] Adapt manager to use products
b50ac90
@joseivanlopez
[web] Show product and software issues
bd54a8d
@joseivanlopez
[web] Adapt to changes in master
59ca28e
@joseivanlopez
[web] Extract product selection form to separate component
7735ace
@joseivanlopez
[web] Move product selection to products components
825b5e3
@joseivanlopez
[web] Create ProductSelector instead of form
e3122a4
@joseivanlopez
[web] Change icon for summary
a483046
@joseivanlopez
[web] Fix method for getting the registration
3bf7a23
@joseivanlopez
[web] Add EmailInput component
5738769
@joseivanlopez
[web] Some code improvements
85caaef
@joseivanlopez
[web] Add product page
403cdde
@joseivanlopez
[service] Do not automatically probe software after registration
33cf3a6
@joseivanlopez
[web] Fix tests
298dd3c
@joseivanlopez
[web] Remove link for changing the product
310ce71
@joseivanlopez
[web] Add registration section to product page
608cd40
@joseivanlopez
[web] Use password field for registration code
354805c
@joseivanlopez
[web] Improve product section
fae9410
@joseivanlopez
[web] Several improvements from review
0e6c2fd
@joseivanlopez
[web] Use early return
e5e7510
@joseivanlopez
[service] Remove repos from ALP-Dolomite config
f6d5bfe 
- The product has to be registered
@joseivanlopez
Merge pull request #814 from openSUSE/registration-ui
a165dd3 
Registration UI
@joseivanlopez
[service] Changelog
12d4ba4
@joseivanlopez
[web] Changelog
acc1cf2
@joseivanlopez
[rust] Changelog
29665b1
@joseivanlopez
Merge branch 'master' into registration
affdacb
@joseivanlopez
Merge branch 'master' into registration
4b55006
@coveralls
Copy link

coveralls commented Nov 15, 2023 •
edited
Loading

Coverage Status

coverage: 65.554% (-0.02%) from 65.578%
when pulling 4b55006 on registration
into 57a31cb on master.

dgdavid
dgdavid approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'd have referenced the "specific" PRs in the changelog files. But it's ok as it is.

Thanks Iván for such a long set of changes,

+5,131
-1,089

@joseivanlopez joseivanlopez merged commit ab65300 into master Nov 15, 2023
5 of 6 checks passed
@joseivanlopez joseivanlopez deleted the registration branch November 15, 2023 14:48
@imobachgs imobachgs mentioned this pull request Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joseivanlopez @coveralls @dgdavid @jreidinger