Localization #881
Merged
Localization #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Additionally, consider as supported all the locales known to systemd. * Rename LabelsForLocales to ListLocales.
* Include the code, the language and the territory name. * Use the UILocale for translations.
- One context for installer localization and another for target system localization.
joseivanlopez
force-pushed
the
localization
branch
from
35f9f38
to
caf8451
Compare
* Most probably, we will need to bring it back in the future.
It fixes a potential problem when calling #on_language_change on different objects.
joseivanlopez
commented
Nov 29, 2023
joseivanlopez
commented
Nov 30, 2023
dgdavid
approved these changes
Nov 30, 2023
| padding-top: var(--pf-v5-c-modal-box__body--PaddingTop); | ||
| background-color: var(--pf-v5-c-modal-box--BackgroundColor); | ||
|
|
||
| [role="search"] { |
There was a problem hiding this comment.
NOTE for my self: we should unify the search input (now we have two styles, the one used in Software page and this)
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
Merged
1 task
Closed
mvidner
added a commit
that referenced
this pull request
Feb 7, 2024
## Problem In #881 localization was improved and works in the web UI. This PR adds CLI and autoinstallation - https://trello.com/c/AvrY5iBP ## Solution Mimic the structure of the other configuration scopes. TODO: - [x] decide where to use `locale` and/or `localization` in the code: mostly "localization" except the D-Bus proxy which is "locale" ## Testing - Tested manually - More unit tests for `KeymapId` ## Screenshots `agama config show` now works for `localization`: ```console 7e24bb397c23:/checkout # (cd rust/; cargo run --bin agama -- -f yaml config show) [... Compiling ...] Running `target/debug/agama -f yaml config show` user: fullName: '' [... etc ...] localization: language: en_US keyboard: us timezone: Europe/Berlin ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Agama already offers a D-Bus interface for localizing both the installer and the target system. But the web UI does not allow to select a keyboard or timezone yet.
Solution
The localization page was redesigned in order to allow changing language, keyboard and timezone for the target system.
The D-Bus API also needed some rework. Now it offers an API adapted to what clients need: listing locales, keymaps and timezones, and also selecting locales, keymap and timezone.
Note: Auto-installation is out of the scope of this PR.
Testing
Screenshots
System in Spanish with GNOME Desktop
UI