Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global issues page and start using popup instead #886

Merged
merged 70 commits into from
Jan 8, 2024

Commits on Nov 18, 2023

  1. Configuration menu
    Copy the full SHA
    c520b56 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    47d04f4 View commit details
    Browse the repository at this point in the history
  2. added warning button to siderbar

    Also removed notification mark
    balsa-asanovic committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    65b2ccb View commit details
    Browse the repository at this point in the history
  3. added className prop for styling

    Removed title prop as popover is no longer used.
    Added sectionName prop used to determine highlighting on the issues popup
    balsa-asanovic committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8a68dcc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3754f47 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. converted page to popup

    Added prop for closing popup
    Added sectionHighlight prop used to determine which section to highlight
    Added autoscroll to the appropriate section based on sectionHighlight
    balsa-asanovic committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c73c8cd View commit details
    Browse the repository at this point in the history
  2. Removed popover, now it opens Issues popup

    Added sectionName prop to determine which section is rendering the comp
    Removed title prop as it is not used anymore
    balsa-asanovic committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    951fe01 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e5e85bc View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Configuration menu
    Copy the full SHA
    dfdfd9d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eff9b15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3195346 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3df181b View commit details
    Browse the repository at this point in the history
  5. gemfile.lock reverts

    balsa-asanovic committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4b92d6b View commit details
    Browse the repository at this point in the history
  6. changed color for highlighting

    added class for warning icon color
    balsa-asanovic committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3f011a0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8223e4f View commit details
    Browse the repository at this point in the history
  8. switched to using a single ref hook

    This ref is passed to section comp which now takes it as a prop
    balsa-asanovic committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d916474 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cd0a59e View commit details
    Browse the repository at this point in the history
  10. changed the look of the issues button

    Uses orange color for warning icon
    balsa-asanovic committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ef57b49 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    7ae32ff View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. Configuration menu
    Copy the full SHA
    5cff43d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    12a17ef View commit details
    Browse the repository at this point in the history
  3. changes prop name from sectionHighlight to openFrom

    removed skeleton and replaced it with big icon loading
    
    added <div classname="stack> to sections part
    balsa-asanovic committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    1d28178 View commit details
    Browse the repository at this point in the history
  4. sectionHighlight prop to openFrom

    adjusted prop description
    balsa-asanovic committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    a68509f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    221cb19 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e27ff67 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Configuration menu
    Copy the full SHA
    fdd374d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50f5d42 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c575e28 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    15e0614 View commit details
    Browse the repository at this point in the history
  5. IssuesDialog now only shows issues from a single section

    Removed both highlighting and scrolling mechanisms
    Since only one section is shown, they make no sense
    balsa-asanovic committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    3dbd8e6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f9f85a8 View commit details
    Browse the repository at this point in the history
  7. Removed link to Issues page which no longer exists

    Reworded the message to encourage the users to go back and check in case of issues
    
    Set Cancel as primary action and Accept as secondary action
    balsa-asanovic committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    eb24b4c View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Configuration menu
    Copy the full SHA
    6727d29 View commit details
    Browse the repository at this point in the history
  2. classes no longer used

    balsa-asanovic committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    97f1343 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae4971e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4089b08 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9ff2b8f View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. Configuration menu
    Copy the full SHA
    2f62c18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a6a126 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc464b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f272ef3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc693bd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bf745c8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    afc7dae View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dcfc69a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    bd4c91a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. removed red color and warning icon from issueItem

    set aria-label to "List of issues"
    balsa-asanovic committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6705f81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a6aa29 View commit details
    Browse the repository at this point in the history
  3. removed IssuesLink

    balsa-asanovic committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    16e6b9c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d0ffa4f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dc80336 View commit details
    Browse the repository at this point in the history
  6. more simplification of IssuesDialog code

    removed internal components
    
    added Title as prop
    balsa-asanovic committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    27a0127 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bd72c6e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    651211f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f5dad31 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5ea7aab View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0df8a30 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. [web] Please linters

    dgdavid committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    bddb6b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e97140 View commit details
    Browse the repository at this point in the history
  3. [web] Update ValidationErrors component test

    It was needed to mock the core/IssuesDialog component to keep the test
    simple instead of mocking the client and having to test things that
    actually belongs to IssuesDialog component
    dgdavid committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8a45d9b View commit details
    Browse the repository at this point in the history
  4. [web] Do not use core/Section for list of issues

    Since core/Section is reserving space for icons, it looks a bit weird
    when used inside a dialog for displaying a list of items. Too much space
    on the left.
    
    Thus, stop using it by now until the component allows conditionally
    reserve such an space or not depending on whatever, a prop or parent.
    
    Also, start using a plain HTML <ul> element instead of the PF/HelperText
    for wrapping the list of issues.
    dgdavid committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d4a99e1 View commit details
    Browse the repository at this point in the history
  5. [web] Allow ValidationErrors guess the right issues key

    There are some use cases where the IssuesDialog can be open for a
    "subsection" of a big area. E.g., the "storage-actions" section could
    link to the "storage" issues.
    
    Thus, split the `sectionId` to use only the text found before the first
    dash.
    dgdavid committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e1b7f79 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1260990 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b67cf7d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5ab2ae4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d328700 View commit details
    Browse the repository at this point in the history
  10. removed route for Issues Dialog

    Issues Dialog is not a page and therefore the route is not needed
    balsa-asanovic committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    0e84d9b View commit details
    Browse the repository at this point in the history
  11. changes file update

    balsa-asanovic committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    75d87a1 View commit details
    Browse the repository at this point in the history
  12. [web] Fix styles

    Using margin instead of padding
    dgdavid committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a1a04a5 View commit details
    Browse the repository at this point in the history
  13. [web] Please ESLint

    dgdavid committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e443124 View commit details
    Browse the repository at this point in the history