Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an icon to the "transactional" label #890

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add an icon to the "transactional" label #890

merged 1 commit into from
Nov 24, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Nov 24, 2023

Problem

  • Missing icon in the "transactional" label
  • When Josef implemented the feature he did not find any suitable icon
  • We should use some icon so the UI is unified

Notes

  • Originally I wanted to use the sync_lock icon, but the lock symbol is too small when resized to 12x12 pixels
  • The simpler sync icon looks OK as well

Testing

  • Tested manually

Screenshots

agama-proposal-transactional-icon

@coveralls
Copy link

Coverage Status

coverage: 75.545% (+0.002%) from 75.543%
when pulling 0437c3d on transactional_label_icon
into f746b53 on master.

@lslezak lslezak merged commit e5c8777 into master Nov 24, 2023
@lslezak lslezak deleted the transactional_label_icon branch November 24, 2023 17:56
@imobachgs imobachgs mentioned this pull request Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lslezak @coveralls @dgdavid