Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run the integration tests in forks #908

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Dec 4, 2023

Problem

  • The integration tests use a schedule and are run automatically every day
  • If the integration test fails it reports a failure on our IRC channel
  • But if it fails in a fork it is just spamming the IRC and we cannot do anything about it anyway

Solution

  • Disable scheduled runs in forks, allow only explicit manual run (if somebody wants to be sure it still works fine)
  • Never run the IRC notification in forks, even in manual runs

Additional Fix

  • Run the test 5 minutes earlier to have enough time to check the failure and possibly discuss it on the daily call

@lslezak lslezak merged commit fa993a3 into master Dec 4, 2023
@lslezak lslezak deleted the integration_tests_forks branch December 4, 2023 09:29
@imobachgs imobachgs mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants