Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the user visible patterns configurable, added MicroOS products #916

Merged
merged 15 commits into from
Dec 6, 2023
Merged

Make the user visible patterns configurable, added MicroOS products #916

merged 15 commits into from
Dec 6, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Dec 5, 2023

Problem

Solution

  • Do not display all available patterns in the pattern selector, display only the explicitly listed patterns configured in the product YAML file

Additional Fixes

  • The Leap 16.0 product has been removed (discussed with Luboš)
  • Added new openSUSE MicroOS products
  • Enhanced the yupdate code to also patch the product definitions

Testing

  • Added new unit tests
  • Tested manually

Screenshots

openSUSE Tumbleweed openSUSE MicroOS
tw-patterns microos-patterns
openSUSE MicroOS Desktop Product Selection
microdesktop-patterns product-selection

lslezak and others added 13 commits December 4, 2023 14:57
@lslezak
yupdate - update also the YAML product files
33e0d22
@lslezak
Define the user visible patterns in the product YAML files
1193ed3
@lslezak
Web - do not display the pattern selector if there are no patterns
8e48e41
@lslezak
service - return only the configured patterns
405d3c6
@ancorgs
Preliminary definitions of openSUSE MicroOS products
4876a11
@ancorgs
Fix pattern name
0eb856c
@ancorgs
Fix base product for MicroOS
988a792
@lslezak
update documentation
515477a
@lslezak
Explicitly add the "translation" sections to the product YAML
de02a86 
Otherwise the automated script would add it at the end of the file.
@ancorgs
List the yast2_basis pattern (installed by default)
acadadc
@lkocman @ancorgs
Drop Leap 16.0 for now
ddcffaa 
* we can probably expect openSUSE variants of Dolomite or Marble
  prior we have Leap 16.0

* Fixes Issue #907
@ancorgs
Update specfile and changelog
7a19b73
@lslezak
Added unit test
9376a72
@coveralls
Copy link

coveralls commented Dec 5, 2023 •
edited
Loading

Coverage Status

coverage: 75.044% (+0.05%) from 74.998%
when pulling 97da667 on user_patterns
into 2c46c58 on master.

ancorgs
ancorgs reviewed Dec 5, 2023
View reviewed changes
Rakefile
FileUtils.mkdir_p(File.dirname(target))
FileUtils.cp(f, target)
else
# if there is a new product file it needs to be copied manually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without putting too much thinking into it... not sure if this is the behavior I would expect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, problem is that it is hard to know which product belongs to which iso

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the Git repository contains YAML files for all product. If you are patching the openSUSE Agama installer then the Live medium contains only the openSUSE products.

If yupdate would install all files you would suddenly see the ALP Dolomite product in the list, that would be confusing. So I decided to patch only the existing files and to not blindly copy everything available. IMHO it is better to have a safer default behavior.

jreidinger
jreidinger reviewed Dec 5, 2023
View reviewed changes
products.d/tumbleweed.yaml
- gnome
- yast2_basis
- yast2_desktop
- yast2_server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it makes sense to have all three. Maybe just desktop and server yast modules will be enough?

Copy link
Contributor Author

@lslezak lslezak Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. If you want to have YaST just for the package management then the yast2_basis is enough. On the other hand the yast_desktop pattern adds just few megabytes more, not a big deal...

jreidinger
jreidinger approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing critical

@lslezak lslezak merged commit 3953469 into master Dec 6, 2023
7 checks passed
@lslezak lslezak deleted the user_patterns branch December 6, 2023 09:32
@imobachgs imobachgs mentioned this pull request Dec 21, 2023
Merged
imobachgs added a commit that referenced this pull request Dec 21, 2023
@imobachgs
Update to release 7 (#947)
a1c7f33 
* #915
* #916
* #917
* #919
* #920
* #921
* #922
* #923
* #924
* #925
* #926
* #927
* #928
* #929
* #930
* #931
* #933
* #934
* #935
* #936
* #937
* #938
* #939
* #940
* #941
* #942
* #943
* #944
* #945
* #946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancorgs ancorgs ancorgs left review comments

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lslezak @coveralls @jreidinger @ancorgs @lkocman