Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup and CI dependencies #955

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

joseivanlopez
Copy link
Contributor

Problem

Some dependencies have been added, but the setup script and CI tasks do not include them.

Note: we need some way of extracting deps automatically. Having spec, setup and CI manually in sync is error prone.

Solution

Add dependencies.

@jreidinger
Copy link
Contributor

@joseivanlopez btw in ruby we have rake build_dependencies:install # Install the packages required for building maybe we can have something similar also for runtime dependencies

@joseivanlopez
Copy link
Contributor Author

@joseivanlopez btw in ruby we have rake build_dependencies:install # Install the packages required for building maybe we can have something similar also for runtime dependencies

I think that is the idea of the setup script: to install and configure everything for running agama. Not sure if having a task only for installing deps has any value here.

@joseivanlopez joseivanlopez merged commit d624a60 into agama-project:master Dec 22, 2023
1 check passed
@imobachgs imobachgs mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants