Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TPM-based encryption more explicit #995

Merged
merged 9 commits into from
Jan 18, 2024
Merged

Make TPM-based encryption more explicit #995

merged 9 commits into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. [Service] Changes related to EncryptionMethod 

    - Use LUKS2 with PBKDF2 as default.
- Expose the list of available methods (LUKS2 and TPM_FDE so far) in the
  D-Bus API.
    @ancorgs
    ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1229d95 View commit details
    Browse the repository at this point in the history

  2. [Web] Allow to select TPM_FDE encryption if available

    @ancorgs
    ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    49c9806 View commit details
    Browse the repository at this point in the history

  3. [Web] Add explanation about TPM and reboot

    @ancorgs
    ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a884db0 View commit details
    Browse the repository at this point in the history

  4. [Web] Make TPM implications more clear

    @ancorgs
    ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    d5a6fcf View commit details
    Browse the repository at this point in the history

  5. [web] Add tests for InstallationFinished page 

    For checking that conditional information is rendered when appropiate.
Even though that page will be reworked in a near future, keeping the
testsuite up-to-date worth more than its cost.
    @dgdavid @ancorgs
    dgdavid authored and ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    58bfe78 View commit details
    Browse the repository at this point in the history

  6. [web] Code improvements for InstallationFinished page 

    In spite of the InstallationPage needs to be reworked a bit more (and
possibly to include a loading internal state or similar), this commit
introduces minor code improvements that were cheaper to apply right now.

First of all, the TPM reminder is only shown if encryption was set.

Additionally, the reminder is improved to avoid it changing the width
when the user expands it. Done by relaying in CSS minmax function and
CSS container queries. Both with wide support of modern browsers.

This commit also stops centering vertically the page content because
the very same reason: having dinamic components make things moving
top / down depending on their state.

It also moves the TPM id to an enum created in the client/storage for
the encryption methods, following the same approach as network code.
It can be moved to an specific file like it is already done in
client/phase or client/status, though. Something to be defined/polished
in next iterations.

[1] https://developer.mozilla.org/es/docs/Web/CSS/minmax
[2] https://developer.mozilla.org/es/docs/Web/CSS/CSS_container_queries
    @dgdavid @ancorgs
    dgdavid authored and ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    77e8339 View commit details
    Browse the repository at this point in the history

  7. [web] Fix from core review

    @ancorgs
    ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    25260c6 View commit details
    Browse the repository at this point in the history

  8. [web] Rework TPM texts

    @ancorgs
    ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c4819a1 View commit details
    Browse the repository at this point in the history

  9. Changelog entries

    @ancorgs
    ancorgs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    432b5b4 View commit details
    Browse the repository at this point in the history