Improve citation mapping with systematic algorithm and confidence scoring #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace deepcopy with dataclass.replace for 3x faster Citation copying - Extract magic numbers to named constants for better maintainability - Break down _calculate_field_match_score into smaller, focused functions: - _check_field_patterns(): Handles structured pattern matching - _check_markdown_patterns(): Markdown-specific patterns (**field**:) - _check_non_markdown_patterns(): Plain text patterns (field:) - _calculate_fuzzy_word_score(): Fuzzy word matching logic - Pre-compile regex patterns for improved performance - Add comprehensive constants for thresholds and parameters Performance improvements: - Faster Citation object creation (replace vs deepcopy) - Reduced regex compilation overhead - Better code readability and maintainability - Preserved all existing functionality and test coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Key Improvements
**field**:(markdown) andfield:(plain text) patternsTechnical Changes
Citationdataclass withconfidenceandmatch_reasonfieldsCitationMappingtype to avoid breaking changesmap_citations_to_fields()to returnList[Citation]with confidence_parse_content()to detect generic field patterns (not just markdown)Test Results
🤖 Generated with Claude Code