Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix easings function context #22

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix easings function context #22

merged 1 commit into from
Sep 19, 2023

Conversation

agargaro
Copy link
Owner

@agargaro agargaro commented Sep 19, 2023 •
edited
Loading

Fixed the exception generated in easing functions that used the 'this' reference, like this:

public easeInBounce(x: number): number {
    return 1 - this.easeOutBounce(1 - x);
}

@agargaro agargaro added the bug Something isn't working label Sep 19, 2023
@agargaro agargaro added this to the r2 milestone Sep 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agargaro agargaro merged commit f773c85 into master Sep 19, 2023
1 check passed
@agargaro agargaro deleted the Fix-easings-function-context branch September 19, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
r2
Development

Successfully merging this pull request may close these issues.
1 participant
@agargaro