Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple build failures from new nightlies #393

Closed
4 tasks done
gwilymk opened this issue Mar 8, 2023 · 2 comments
Closed
4 tasks done

Multiple build failures from new nightlies #393

gwilymk opened this issue Mar 8, 2023 · 2 comments

Comments

@gwilymk
Copy link
Contributor

gwilymk commented Mar 8, 2023

Nightly releases contain some bugs that mean agb doesn't compile.

We will keep track of these failures. If you are using a released agb version, instead you can use the nightly version as of the day it was released. If you're using master, we will mitigate issues where possible, check the nightly action build for the most recent working nightly build.

In order to use a different Rust version, you can change the version in the rust-toolchain.toml file to explicitly state the nightly version, for example

[toolchain]
channel = "nightly-2023-05-04"
@gwilymk
Copy link
Contributor Author

gwilymk commented Mar 29, 2023

Another issue (different from the first) rust-lang/rust#109730

@corwinkuiper
Copy link
Collaborator

Re: the first issue:

  • We resolved the issue by switching from opt-level of s to 3 for the release mode build.
  • We then had to resolve a run time issue in one of the save tests (potential miscompilation). Switch from lto of "thin" to "fat".

gwilymk added a commit that referenced this issue Apr 5, 2023
Workaround for #393 

- [x] Changelog updated / no changelog update needed
@corwinkuiper corwinkuiper pinned this issue May 5, 2023
@corwinkuiper corwinkuiper changed the title Build failing since nightly release on 2023-02-27 Multiple build failures from new nightlies May 5, 2023
@gwilymk gwilymk unpinned this issue Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants