Skip to content

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jun 20, 2025

This a conservative refactoring which:

  • cleans up the proof of Relation.Nullary.Decidable.True-↔ to:
    • [ cosmetic ] reuse existing definitions toWitness/fromWitness from Relation.Nullary.Decidable.Core
    • [ add ] appeal to a new local lemma from-to which could be lifted out to top-level?
  • [ refactor ] avoids the redundant repetition in Function.Related.TypeIsomorphisms by a public renaming export of the above, cf. [DRY] Refactor algebraic properties of types #2489
  • cleans up the proof of Relation.Nullary.Decidable.via-injection to:
    • [ cosmetic] clarify the local opening of the Injection argument injection
  • tidies up the relevant imports to reflect the above refactorings

As such, no CHANGELOG required, but could potentially:

  • add from-to (suitably named) as top-level lemma
  • deprecate Function.Related.TypeIsomorphisms.True↔ in favour of Relation.Nullary.Decidable.True-↔

@jamesmckinna jamesmckinna added this to the v2.3 milestone Jun 20, 2025
@jamesmckinna jamesmckinna changed the title [ refactor ] proofs in Relation.Nullary.Decidable and its reexport in Function.Related.TypeIsomorphisms [ refactor ] proofs in Relation.Nullary.Decidable and a reexport in Function.Related.TypeIsomorphisms Jun 20, 2025
@MatthewDaggitt MatthewDaggitt added this pull request to the merge queue Jun 25, 2025
Merged via the queue into agda:master with commit 32f786e Jun 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants