-
Notifications
You must be signed in to change notification settings - Fork 249
[ refactor ] (more) decidable Data.Fin.Properties
#2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Data.Fin.Properties
Data.Fin.Properties
Thanks @MatthewDaggitt for the feedback:
I'll move to DRAFT for the time being, and remove from v2.3, while I reconsider things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the code seems fine. Only issues are that things seem to have moved without a good reason to.
Hmmm... @JacquesCarette the code motion was in response to earlier review comments from @MatthewDaggitt , but maybe I misunderstood his intention. Nevertheless, the |
I had seen some of the conversation. This is why maybe a larger break up ( |
Last addition: dual version of |
This PR refactors some proofs about
Decidable
predicates onFin n
, to clarify some, and to add others, including some additionalsyntax
, around a independently interesting minimisation principle from which certain others follow.A downstream refactoring might reconsider these things in terms of specialisation of lemmas in
Induction.InfiniteDescent
.Outstanding issue: could be more systematic about use of
variable
s to clean the whole module up?